Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update status of verified configs #198

Merged
merged 2 commits into from
Sep 14, 2023
Merged

update status of verified configs #198

merged 2 commits into from
Sep 14, 2023

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Sep 11, 2023

This adds exynos5 as verified configuration and marks the verification of imx8mm as maintained.

  • updates the hardware status page
  • updates the verified configs page
  • points to cmake configs in the seL4 repo

@lsf37 lsf37 self-assigned this Sep 11, 2023
@Ivan-Velickovic
Copy link
Contributor

Ivan-Velickovic commented Sep 12, 2023

The naming of the i.MX boards is inconsistent, ARM Sabre Lite is iMX.6 but i.MX8MM-EVK is referred to as iMX8 MM and IMX8MM-EVK. Is the platform field supposed to be human readable or is it supposed to be seL4's name for the platform?

The config ARM Sabre Lite says that its platform is iMX.6 (e.g. Sabre Lite). The e.g implies that the Sabre Lite is one kind of platform that is supported, but the title implies only the Sabre Lite is supported? What is correct?

@Ivan-Velickovic
Copy link
Contributor

Another comment (not relevant to this PR) is that all the 32-bit ARM configs are named differently depending if hypervisor mode is supported or not but the AARCH64 configuration does not have HYP in the name, even though it does support hypervisor mode.

@Ivan-Velickovic
Copy link
Contributor

Another comment (not relevant to this PR) is that all the 32-bit ARM configs are named differently depending if hypervisor mode is supported or not but the AARCH64 configuration does not have HYP in the name, even though it does support hypervisor mode.

From memory this is a historical thing which probably can't be changed at this point but it's one of the things that makes this page more confusing than it should be (in my opinion).

@lsf37
Copy link
Member Author

lsf37 commented Sep 12, 2023

Another comment (not relevant to this PR) is that all the 32-bit ARM configs are named differently depending if hypervisor mode is supported or not but the AARCH64 configuration does not have HYP in the name, even though it does support hypervisor mode.

From memory this is a historical thing which probably can't be changed at this point but it's one of the things that makes this page more confusing than it should be (in my opinion).

It's something we eventually want to get rid of (but currently can't for the old stuff), so we've decided to keep it clean for AARCH64 at least. It does make it inconsistent, but the hope is to resolve that in the future.

@lsf37
Copy link
Member Author

lsf37 commented Sep 12, 2023

The naming of the i.MX boards is inconsistent, ARM Sabre Lite is iMX.6 but i.MX8MM-EVK is referred to as iMX8 MM and IMX8MM-EVK. Is the platform field supposed to be human readable or is it supposed to be seL4's name for the platform?

The config ARM Sabre Lite says that its platform is iMX.6 (e.g. Sabre Lite). The e.g implies that the Sabre Lite is one kind of platform that is supported, but the title implies only the Sabre Lite is supported? What is correct?

Tbh, I was confused about that as well. The config file for just ARM has set(KernelPlatform "imx6" CACHE STRING "") which does not explicitly select sabre, but sabre is then picked as default and it is relatively certain that other boards will not work automatically. So the e.g. is wrong.

I guess this means the heading for the other one should be i.MX8MM-EVK

@lsf37
Copy link
Member Author

lsf37 commented Sep 12, 2023

Ok, I've pushed a new version with an attempt at more consistency. The platform/soc/board names are already not very consistent in the main hardware table, esp between the imx platforms. I've defaulted to using the same string as in that table (which gives is ARM IMX8MM-EVK for that config we talked about above), and I've removed the e.g. bits from the table that were a bit misleading.

@kent-mcleod
Copy link
Member

arm_hyp could be removed, it's a big change, but doesn't affect verification and so should be tractable.

@lsf37
Copy link
Member Author

lsf37 commented Sep 13, 2023

arm_hyp could be removed, it's a big change, but doesn't affect verification and so should be tractable.

We might be talking about different ARM_HYP things -- ARM_HYP is the name of the verification L4V_ARCH setting that selects the Arm 32 bit proofs with hyp. It's also a cmake setting. The cmake setting could be changed without affecting verification, I think, but the name would still be mentioned on this page because the name also encodes proof selection.

Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense and looks correct to me.

@lsf37 lsf37 merged commit a83ee45 into master Sep 14, 2023
8 checks passed
@lsf37 lsf37 deleted the verfied-configs branch September 14, 2023 08:24
@Ivan-Velickovic
Copy link
Contributor

Ok, I've pushed a new version with an attempt at more consistency. The platform/soc/board names are already not very consistent in the main hardware table, esp between the imx platforms. I've defaulted to using the same string as in that table (which gives is ARM IMX8MM-EVK for that config we talked about above), and I've removed the e.g. bits from the table that were a bit misleading.

Thanks for making it less confusing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants